fix(firebase_auth): TenantId can be reset to null after being set to something else#7897
Open
Rexios80 wants to merge 1 commit intofirebase:masterfrom
Open
fix(firebase_auth): TenantId can be reset to null after being set to something else#7897Rexios80 wants to merge 1 commit intofirebase:masterfrom
Rexios80 wants to merge 1 commit intofirebase:masterfrom
Conversation
Rexios80
changed the title
Contributor
Author
|
Welp it looks like this issue goes deeper than just this plugin In the native Android SDK: public void setTenantId(@NonNull String param1) {
// $FF: Couldn't be decompiled
}I don't think that code is open source, so I'm stuck on this. I definitely think you're supposed to be able to set the tenantId back to null. The iOS and web SDKs let you, and the value defaults to null anyways. |
Member
|
Hey @Rexios80, this is worth raising on the firebase-android-sdk I believe. It looks like it probably shouldn't be |
Member
|
@Rexios80 please let me know if you've raised an issue for this and we can mention it to the Android SDK devs |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Existing behavior
New behavior
Motivation
I was unsure how to write tests for this. The existing tenantId tests don't look like they actually interact with the platform code. If anyone could point me in the right direction I would be happy to write them.
Related Issues
#7896 (comment)
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?